Add back onTelemetry handler for desktop - #19254
Merged
Karthik Nadig (karthiknadig) merged 1 commit intoJun 8, 2022
Merged
Conversation
Karthik Nadig (karthiknadig)
approved these changes
Jun 8, 2022
Member
|
There is no framework to test this right now. We will have to add a new one. For now, I recommend adding work item to create tests for this. |
Member
|
Work item for test: #19261 |
Karthik Nadig (karthiknadig)
pushed a commit
to karthiknadig/vscode-python
that referenced
this pull request
Jun 8, 2022
Add back LanguageClient.onTelemetry call for desktop
Karthik Nadig (karthiknadig)
pushed a commit
that referenced
this pull request
Jun 8, 2022
Add back LanguageClient.onTelemetry call for desktop
Wes McKinney (wesm)
pushed a commit
to posit-dev/positron
that referenced
this pull request
Mar 28, 2024
Add back LanguageClient.onTelemetry call for desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/microsoft/pyrx/issues/2480
The
LanguageClient.onTelemetryhandler that relays telemetry from Pylance was accidentally removed for desktop scenarios in #18884. So allms-python.python/language_server/*events are missing for desktop users on Python 2022.5.11091004 and later.Telemetry still worked for vscode.dev because we still had an
onTelemetryhandler for browser.This PR adds back the removed desktop handler.
I'd love to add a test for this, but didn't see any existing tests that deal with
LanguageClientorNodeLanguageServerProxy. Added #19261 to track adding a test for this scenario.